Add truffle v5 target, switch from BigNumber to BN #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truffle (at least version 5.0.x) use `BN` internally, not BigNumber.
Replace BigNumber with BN.js
…get-truffle-v5, because @ character is not allowed in package names.
…get-truffle-v5, because @ character is not allowed in package names.
krzkaczor
reviewed
Dec 16, 2019
| @@ -0,0 +1,21 @@ | |||
| # Typechain target Truffle | |||
There was a problem hiding this comment.
can u add here Truffle@5 or something?
Yes, they use web3@1 under the hood, but they've created their own wrappers around it. |
|
@pash7ka oh, makes sense. I will finish CR today 👍 |
|
Merged to tmp branch for now - it needs a little bit more work. Thanks for this @pash7ka @MicahZoltu ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #193 and pull requst #184, with v5.0.0 truffle moved from Web3.js v0.x to v1.x. One of major change in it: use of BN.js instead of bignumber.js.
With this pull request i've introduced
typechain-target-truffle-v5based on @MicahZoltu pr #184.